Decrease memory footprint when handling large attachments - #356
Open
csu333 wants to merge 1 commit into
Open
Conversation
feat: added streaming of json webhook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m currently working on a small project where I use WuzAPI on a constrained system (1 GB of RAM). The handling on large attachments such as video just won’t work because of the multiple copies of the objects in memory. To sort that out, I made a few changes:
I made my best not to break any existing feature. People not activating streaming will observe that the message in form-data will have the userID/instanceName information twice (once at top level and once in the form data since it’s injected by sendEventWithWebHook), but they will otherwise benefit from a decrease of the memory footprint (especially when handling large files).
As Go is not my language of preference, I relied on several AI models to produce and review my code. I would therefore understand any push back.